Fix macOS GUI build to bundle customtkinter and set installer title#80
Merged
Conversation
…r customtkinter; set installer title
Code Coverage OverviewLanguages: Python Python / code-coverage/pytestThe overall coverage remains at 75%, unchanged from the branch. Updated |
… causing pip-missing failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix macOS GUI build to bundle customtkinter and show proper installer title
🤔 Why?
🔧 What changed
🧪 How to test
Run the CI mac build or the mac packaging steps locally.
Install the produced .pkg and then run:
/Applications/MkPFS.app/Contents/MacOS/MkPFS
Confirm the GUI launches without ModuleNotFoundError and that the Installer window displays the product title/version.
💬 Notes for non-technical readers